Expose query progress on statement#214
Merged
staticlibs merged 1 commit intoduckdb:mainfrom May 9, 2025
Merged
Conversation
This change exposes the `duckdb_query_progress` native call as `getQueryProgress()` method on the statement. Similar to the `Statement#cancel()` call this new method also expected to be called when `execute()` is running and also works on the connection (not on the statement itself). Note, the local option `SET enable_progress_bar = true` needs to be set to be able to fetch actual progress data. Testing: new test is added that checks that `getQueryProgress()` returns valid values.
Collaborator
Author
|
@lnkuiper I wonder if you would like to take a look at this PR? |
lnkuiper
approved these changes
May 9, 2025
lnkuiper
left a comment
lnkuiper
left a comment
There was a problem hiding this comment.
@staticlibs I have limited JDBC experience, but this looks excellent! Thanks for implementing this so quickly. This is good to go from my side.
Collaborator
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes the duckdb_query_progress native call as
getQueryProgress()method on the statement. Similar to theStatement#cancel()call this new method also expected to be called whenexecute()is running and also works on the connection (not on the statement itself).Note, the local option
SET enable_progress_bar = trueneeds to be set to be able to fetch actual progress data.Testing: new test is added that checks that
getQueryProgress()returns valid values.