Ignore path option passed by Spark#184
Merged
staticlibs merged 1 commit intoduckdb:mainfrom Apr 9, 2025
Merged
Conversation
staticlibs
force-pushed
the
spark_path_option
branch
2 times, most recently
from
ed0cac2 to
23136a7
Compare
Apache Spark passes the `path` option when a SELECT on a JDBC DataSource table is performed. It is the internal Spark option and is likely passed by mistake, so we need to ignore it to allow the connection to be established. Testing: new test added that checks that the `path` option is ognored. Fixes: duckdb#55
staticlibs
force-pushed
the
spark_path_option
branch
from
23136a7 to
4583b9a
Compare
Collaborator
Author
|
Merging as reviewed offline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache Spark passes the
pathoption when a SELECT on a JDBC DataSource table is performed. It is the internal Spark option and is likely passed by mistake, so we need to ignore it to allow the connection to be established.Testing: new test added that checks that the
pathoption is ignored.Fixes: #55