Add def to max & find #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YJorge
reviewed
Feb 12, 2024
Comment on lines
5
to
8
| max = array[0] | ||
| array.each do |i| | ||
| max = i if i >= max | ||
| end |
There was a problem hiding this comment.
вынеси поиск максимума вотдельный метод
YJorge
reviewed
Feb 12, 2024
test/exercise/arrays/solution.rb
Outdated
| right = array.length - 1 | ||
| left = 0 | ||
|
|
||
| while left <= right |
Author
There was a problem hiding this comment.
можно в функцию добавить новый параметр ?, например, счетчик, если да, то его также надо добавить в test.rb
There was a problem hiding this comment.
можно добавить, но так, чтобы не править тесты. Посмотри про аргументы со значением по умолчанию или с ключевым словом
YJorge
reviewed
Feb 12, 2024
test/exercise/arrays/solution.rb
Outdated
|
|
||
| while left <= right | ||
| mid = (left + right) / 2 | ||
| if array[mid] == query |
YJorge
reviewed
Feb 12, 2024
test/exercise/arrays/solution.rb
Outdated
| def search(_array, _query) | ||
| 0 | ||
| def search(array, query) | ||
| right = array.length - 1 |
AndreyChim
force-pushed
the
exercise
branch
2 times, most recently
from
cce68b6 to
700f4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.