This repository was archived by the owner on Mar 25, 2024. It is now read-only.
more string quoting #398
Open
more string quoting #398
+114
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzgregor
reviewed
Dec 20, 2023
| || lower_scalar == "null" | ||
| || lower_scalar == "nil" | ||
| || lower_scalar == "~" | ||
| || lower_scalar == "nan" |
There was a problem hiding this comment.
It would be great if this would also cover the float or string issue: https://hitchdev.com/strictyaml/why/implicit-typing-removed/#string-or-float
There was a problem hiding this comment.
fzgregor
reviewed
Dec 20, 2023
| "NULL", | ||
| "nil", | ||
| "Nil", | ||
| "NIL", |
There was a problem hiding this comment.
A test string for float or string would be 2E234567
|
@thedavidmeister what's your thinking about this PR? Is it ready to be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #397 #319