Improve tests #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cept methods in its own scope
…ing, doesn't throw error
Merged
Contributor
Author
|
This PR has been included in the following PRs as dependency: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DistributedSchedulerServiceIgnite can only use runnable classes that are in the classpath, which made testing the
DistributedSchedulerServicea bit tricky since traditionally tests are not in the classpath. My solution was to compile classes in the test folder in_Events.groovy, but exclude them from the war file inBuildConfig.groovy.This PR leaves one failing test, as it is unclear whether or not the l2 cache is currently working or not, and it is an experimental feature anyway. I'll create a separate issue for that.