Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2026

Bumps jfmengels/elm-review-common from 1.3.4 to 1.3.5.

Changelog

Sourced from jfmengels/elm-review-common's changelog.

[1.3.5] - 2025-12-30

  • [NoDeprecated] now includes the deprecation message in the error details when one can be found.
  • [NoPrematureLetComputation] can now move let declarations whose pattern introduces multiple values. In the example below, only (1) could get moved, but with this update (2) can get moved as well.
-- (1)
let
  { x } = value
in
some code
-- (2)
let
{ x, y } = value
in
some code

  • [NoPrematureLetComputation] can now move let declarations that have names in their scope. This was previously purposefully reported but not automatically fixed, as moving a declaration could introduce compiler errors about shadowing.
let
  fn a =
    a
in
case value of
  Just a ->
    fn a
  Nothing ->
    Nothing
-->
case value of
  Just a ->
    let
      fn a = -- `a` is already defined two lines above
        a
    in
    fn a
  Nothing ->
    Nothing

We now detect whether such a compiler error would occur and only prevent the fix in that case.

  • [NoPrematureLetComputation] now preserves comments. Previously, losing comments would be fairly common.
  • [NoPrematureLetComputation] now produces more precise fixes that should be easier to view in suggested fixes.
  • [NoPrematureLetComputation] can now move a let declaration inside Tuple.mapBoth functions.
  • Corrected an automatic fix for [NoPrematureLetComputation] that resulted in incorrect syntax.
Commits
  • 0c11e07 1.3.5
  • 15925d6 Simplify tests
  • e76aa14 NoDeprecated: Include deprecation message in error details
  • 42776ec Remove predicates from configuration
  • 3d4c9e9 Use Rule.withModuleName
  • 064f2cf Mention parameters in elements that get reported
  • da4793e Fix test title
  • 147a99c NoPrematureLetComputation: Preserve comments in fixes
  • 7ddf369 Fix collision detection in lambdas
  • 603bc17 NoPrematureLetComputation: Support moving declarations into Tuple.mapBoth
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 3, 2026
Bumps [jfmengels/elm-review-common](https://github.com/jfmengels/elm-review-common) from 1.3.4 to 1.3.5.
- [Changelog](https://github.com/jfmengels/elm-review-common/blob/main/CHANGELOG.md)
- [Commits](jfmengels/elm-review-common@1.3.4...1.3.5)

---
updated-dependencies:
- dependency-name: jfmengels/elm-review-common
  dependency-version: 1.3.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/elm/review/develop/jfmengels/elm-review-common-1.3.5 branch from 114fcc7 to 9227021 Compare January 14, 2026 14:14
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 14, 2026

Looks like jfmengels/elm-review-common is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jan 14, 2026
@dependabot dependabot bot deleted the dependabot/elm/review/develop/jfmengels/elm-review-common-1.3.5 branch January 14, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants