Skip to content

Conversation

@gabaldon
Copy link

@gabaldon gabaldon commented Dec 19, 2024

  • Allow scrolling when y overflow
  • Adjust table responsive
  • Adjust card margins and home layout

@gabaldon gabaldon changed the title Fix scroll when overflow Fix scroll and responsive Jan 21, 2025
@drcpu-github
Copy link
Owner

If you wish I can put this patch live on the test-version of the explorer though it probably does not matter?

@Tommytrg
Copy link

This PR lgtm, @drcpu-github could you review it? There are only some UI improvements that shouldn't break anything


return (
<Pagination size="sm" style={{float: "right", marginBottom: "0rem"}}>
<Pagination size="sm" style={{ marginBottom: "0rem"}}>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the goal of removing this attribute? On my browser, it now puts the paginator and label on top of each other instead of one in the left corner and one in the right.
float_right_1
float_right_2

Copy link
Author

@gabaldon gabaldon Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better for responsive. The overall idea of this PR is to have the minimum required to display the data on mobile. The plan is to create a second iteration where we will redesign some of the basic components, improve the visual appearance, and enhance the responsiveness of tables.

@drcpu-github
Copy link
Owner

The network stats now all have a useless scrollbar on the right side?

network_stats_1
network_stats_2

@drcpu-github
Copy link
Owner

On mobile, the home screen is definitely improved, but the margins of the first box with some general statistics seem off resulting in a horizontal scrollbar.

Screenshot_20250201-162100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants