Skip to content

Fix project context refresh handling on client #8933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dibarbet merged 1 commit into from
Jan 30, 2026
+5 −5
Merged

Fix project context refresh handling on client #8933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lsptoolshost/projectContext/projectContextFeature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class ProjectContextFeature implements DynamicFeature<RoslynProtocol.Proj
this._client = client;
this._registrations = new Map();
this.registrationType = new ProtocolNotificationType0<RoslynProtocol.ProjectContextRegistrationOptions>(
RoslynProtocol.ProjectContextRefreshNotification.method
RoslynProtocol.ProjectContextRefreshRequest.method
);
}
fillInitializeParams?: ((params: InitializeParams) => void) | undefined;
Expand Down
4 changes: 2 additions & 2 deletions src/lsptoolshost/projectContext/projectContextService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import * as vscode from 'vscode';
import { RoslynLanguageServer } from '../server/roslynLanguageServer';
import {
ProjectContextRefreshNotification,
ProjectContextRefreshRequest,
VSGetProjectContextsRequest,
VSProjectContext,
VSProjectContextList,
Expand Down Expand Up @@ -85,7 +85,7 @@ export class ProjectContextService {
}
});

_languageClient.onNotification(ProjectContextRefreshNotification.type, async () => {
_languageClient.onRequest(ProjectContextRefreshRequest.type, async () => {
await this.refresh();
});

Expand Down
4 changes: 2 additions & 2 deletions src/lsptoolshost/server/roslynProtocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,10 @@ export namespace VSGetProjectContextsRequest {
export const type = new RequestType<VSGetProjectContextParams, VSProjectContextList, void>(method);
}

export namespace ProjectContextRefreshNotification {
export namespace ProjectContextRefreshRequest {
export const method = 'workspace/projectContext/_vs_refresh';
export const messageDirection: MessageDirection = MessageDirection.serverToClient;
export const type = new NotificationType(method);
export const type = new RequestType0(method);
}

export namespace FeatureProvidersRefreshNotification {
Expand Down