Skip to content

Remove obsolete ILLink dependency analyzer project and references#125242

Merged
sbomer merged 2 commits intomainfrom
copilot/remove-unused-illink-analyzer
Mar 6, 2026
Merged

Remove obsolete ILLink dependency analyzer project and references#125242
sbomer merged 2 commits intomainfrom
copilot/remove-unused-illink-analyzer

Conversation

Copy link
Contributor

Copilot AI commented Mar 5, 2026

This change removes the unused ILLink dependency analyzer under src/tools/illink/src/analyzer and eliminates all repository wiring that still referenced it. The ILLink toolset surface now reflects only actively maintained components.

  • Build graph cleanup

    • Removed analyzer from eng/Subsets.props (tools.illink subset no longer builds src/analyzer/analyzer.csproj).
  • Solution cleanup

    • Removed src/analyzer/analyzer.csproj from:
      • src/tools/illink/illink.slnx
      • src/tools/illink/trimming.slnx
  • Source removal

    • Deleted src/tools/illink/src/analyzer/ (project file, core implementation, and analyzer-specific README).
  • Docs alignment

    • Updated src/tools/illink/README.md to remove the “Dependencies Analyzer” section/link to the removed component.
<!-- removed from eng/Subsets.props -->
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@github-actions github-actions bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Mar 5, 2026
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Mar 5, 2026
Copilot AI changed the title [WIP] Remove the unused ILLink analyzer and references Remove obsolete ILLink dependency analyzer project and references Mar 5, 2026
@sbomer sbomer marked this pull request as ready for review March 6, 2026 00:37
@sbomer sbomer requested review from a team and Copilot March 6, 2026 00:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete ILLink dependency analyzer tool from the repository and cleans up remaining build/solution/docs wiring so the ILLink toolset reflects only actively maintained components.

Changes:

  • Removed the analyzer project from the tools.illink build subset.
  • Removed the analyzer project from ILLink solution (.slnx) files.
  • Deleted the analyzer project sources and removed the corresponding documentation section/link.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/Subsets.props Drops src/tools/illink/src/analyzer/analyzer.csproj from the tools.illink subset build graph.
src/tools/illink/illink.slnx Removes the analyzer project entry from the ILLink solution definition.
src/tools/illink/trimming.slnx Removes the analyzer project entry from the trimming solution definition.
src/tools/illink/README.md Removes the “Dependencies Analyzer” documentation section/link.
src/tools/illink/src/analyzer/analyzer.csproj Deleted obsolete analyzer project file.
src/tools/illink/src/analyzer/README.md Deleted analyzer-specific README.
src/tools/illink/src/analyzer/Main.cs Deleted analyzer CLI entrypoint.
src/tools/illink/src/analyzer/ConsoleDependencyGraph.cs Deleted analyzer console output implementation.
src/tools/illink/src/analyzer/LinkerAnalyzerCore/DependencyGraph.cs Deleted analyzer core dependency graph implementation.
src/tools/illink/src/analyzer/LinkerAnalyzerCore/SpaceAnalyzer.cs Deleted analyzer space analysis implementation.

@sbomer
Copy link
Member

sbomer commented Mar 6, 2026

/ba-g "timeout/dead-letter"

@sbomer sbomer merged commit fa46e22 into main Mar 6, 2026
178 of 186 checks passed
@sbomer sbomer deleted the copilot/remove-unused-illink-analyzer branch March 6, 2026 17:17
@github-project-automation github-project-automation bot moved this to Done in AppModel Mar 6, 2026
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? I don't think I've ever seen tlens before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used it myself, seems like another one we could delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants