Fix assertion typo in ReadNamedBitList test#125229
Closed
Conversation
Assert.Equal(actual, actual) was always true. Changed to Assert.Equal(allTheBytes, actual) to properly verify the result. Co-authored-by: vcsjones <361677+vcsjones@users.noreply.github.com>
Member
|
@copilot these changes look good but it is still marked as WIP. Is there anything else to do here? |
vcsjones
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a typo in the ReadNamedBitList_BitArray_EveryPattern test so it validates the decoded bytes against the expected sequence instead of trivially comparing actual to itself.
Changes:
- Corrected the assertion to compare
allTheBytes(expected) withactual(decoded result).
You can also share your feedback on Copilot code review. Take the survey.
Member
|
Superseded by #125254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.