[clr-interp] Fix timing of UnhandleException handlers #122992
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The previous logic would run them after finally's, but this change makes them happen when we detect the unhandled exception during first pass EH. Fixes the baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread test
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the timing of UnhandledException handlers in the CoreCLR interpreter to trigger during the first pass exception handling rather than after finally blocks execute. This resolves a test failure in the baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread test.
Key Changes
- Introduces a flag to track when an InterpreterFrame represents a native transition boundary
- Uses this flag to correctly skip the InterpreterFrame when checking for unhandled exceptions
- Ensures unhandled exception detection happens at the correct point in the exception handling flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread test