Skip to content

[RuntimeAsync] Do not hold to the last used Continuation in the runtime async tasks. #121460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2025
+18 −4
Merged

[RuntimeAsync] Do not hold to the last used Continuation in the runtime async tasks. #121460

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc58bb0
Enable async feature/tests
VSadov Oct 18, 2025
fe10fa8
Do not hold to the last used Continuation in the runtime async tasks.
VSadov Nov 7, 2025
f2bfa91
Revert "Enable async feature/tests"
VSadov Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ...oreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private static void TransparentAwait(object o)
private interface IRuntimeAsyncTaskOps<T>
{
static abstract Action GetContinuationAction(T task);
static abstract Continuation GetContinuationState(T task);
static abstract Continuation MoveContinuationState(T task);
static abstract void SetContinuationState(T task, Continuation value);
static abstract bool SetCompleted(T task);
static abstract void PostToSyncContext(T task, SynchronizationContext syncCtx);
Expand Down Expand Up @@ -297,9 +297,16 @@ void ITaskCompletionAction.Invoke(Task completingTask)
private struct Ops : IRuntimeAsyncTaskOps<RuntimeAsyncTask<T>>
{
public static Action GetContinuationAction(RuntimeAsyncTask<T> task) => (Action)task.m_action!;
public static Continuation GetContinuationState(RuntimeAsyncTask<T> task) => (Continuation)task.m_stateObject!;
public static Continuation MoveContinuationState(RuntimeAsyncTask<T> task)
{
Continuation continuation = (Continuation)task.m_stateObject!;
task.m_stateObject = null;
return continuation;
}

public static void SetContinuationState(RuntimeAsyncTask<T> task, Continuation value)
{
Debug.Assert(task.m_stateObject == null);
task.m_stateObject = value;
}

Expand Down Expand Up @@ -373,9 +380,16 @@ void ITaskCompletionAction.Invoke(Task completingTask)
private struct Ops : IRuntimeAsyncTaskOps<RuntimeAsyncTask>
{
public static Action GetContinuationAction(RuntimeAsyncTask task) => (Action)task.m_action!;
public static Continuation GetContinuationState(RuntimeAsyncTask task) => (Continuation)task.m_stateObject!;
public static Continuation MoveContinuationState(RuntimeAsyncTask task)
{
Continuation continuation = (Continuation)task.m_stateObject!;
task.m_stateObject = null;
return continuation;
}

public static void SetContinuationState(RuntimeAsyncTask task, Continuation value)
{
Debug.Assert(task.m_stateObject == null);
task.m_stateObject = value;
}

Expand Down Expand Up @@ -429,7 +443,7 @@ public static unsafe void DispatchContinuations<T, TOps>(T task) where T : Task,

DispatcherInfo dispatcherInfo;
dispatcherInfo.Next = t_dispatcherInfo;
dispatcherInfo.NextContinuation = TOps.GetContinuationState(task);
dispatcherInfo.NextContinuation = TOps.MoveContinuationState(task);
t_dispatcherInfo = &dispatcherInfo;

while (true)
Expand Down
Loading