Fix formatting of script tags that have/are tag helpers#12922
Open
davidwengier wants to merge 10 commits intodotnet:mainfrom
Open
Fix formatting of script tags that have/are tag helpers#12922davidwengier wants to merge 10 commits intodotnet:mainfrom
davidwengier wants to merge 10 commits intodotnet:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this while investigating https://developercommunity.visualstudio.com/t/visual-studio-2026-doesnt-format-javasc/11060696
A lot of our cod that detected things like
pre,textarea,scriptetc. tags only checkedMarkupElementSyntax, but since MVC can allow any arbitrary tag to become aMarkupTagHelperElementSyntax, that causes issues. To help solve this once and for all, changing the shape of the syntax tree seemed the most appropriate, same as we did with start and end tag syntax nodes previously. Due to the nature of that change being pretty viral, there is a bit more to review here than just the fix for the bug. I introduced a few new helper properties to help with further targeted simplification too.