Skip to content

Refactor EraseUnions: DU-based domain model for union lowering #19518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T-Gro wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Refactor EraseUnions: DU-based domain model for union lowering #19518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
0a410b7
Add UnionLayout taxonomy + assertions (no behavior change)
T-Gro Mar 26, 2026
63fab4d
Extract shared concerns (nullability, debug proxy)
T-Gro Mar 26, 2026
38c0339
Migrate instruction functions to exhaustive layout matching
T-Gro Mar 26, 2026
17a0cef
Decompose convAlternativeDef into focused sub-functions
T-Gro Mar 27, 2026
ed79b63
Decompose mkClassUnionDef into focused sub-functions
T-Gro Mar 27, 2026
f942cb3
Remove old UnionReprDecisions infrastructure
T-Gro Mar 27, 2026
717bdae
Refactor mkNewData: replace boolean deconstruction with pattern match
T-Gro Mar 27, 2026
1e4ebd2
Deduplicate tyForAlt by reusing altOptimizesToRoot
T-Gro Mar 27, 2026
1a4cfe5
Simplify processAlternative NoHelpers branch with pattern match
T-Gro Mar 27, 2026
faf20c3
Simplify emitTesterMethodAndProperty nullness guard
T-Gro Mar 27, 2026
4d648f0
Simplify emitRootClassFields loop guard with layout match
T-Gro Mar 27, 2026
210eb70
Decompose emitRootConstructors complex guard into named conditions
T-Gro Mar 27, 2026
61bff7a
Replace isStruct bool with layout match in rewriteFieldsForStructFlat…
T-Gro Mar 27, 2026
822e235
Eliminate isSingleNonNullaryFoldedToRoot in favor of altFoldsAsRootIn…
T-Gro Mar 27, 2026
c16a0ef
Eliminate caseFoldsToRootClass, inline via altFoldsAsRootInstance
T-Gro Mar 27, 2026
75c5958
Refactor classifyUnion: use match expression for readable classification
T-Gro Mar 27, 2026
32953dd
Simplify maintainConstantField: replace chained AP-to-bool with match
T-Gro Mar 27, 2026
405c278
Simplify emitNullaryCaseAccessor: match on CaseIsNull directly
T-Gro Mar 27, 2026
9f3d36a
Apply fantomas formatting
T-Gro Mar 27, 2026
8ef493f
Wave 1: Replace avoidHelpers bool with DataAccess DU
T-Gro Mar 27, 2026
13c2bfd
Wave 2: Rename nullCaseIdx→nullAsTrueValueIdx, ListTailOrNull→FSharpList
T-Gro Mar 27, 2026
e62c110
Wave 3: Split allNullary bool into explicit TaggedRef/TaggedRefAllNul…
T-Gro Mar 27, 2026
9667156
Wave 3+4: Split allNullary and SmallRefUnion into explicit DU cases
T-Gro Mar 27, 2026
3e5f134
Wave 5: Remove dead code, eliminate hasNullCase, explicit match arms
T-Gro Mar 27, 2026
9a80a6b
Wave 6: Extract nullnessCheckingEnabled helper, restructure classifyU…
T-Gro Mar 27, 2026
62d3700
Wave 7: Inline doesRuntimeTypeDiscriminateUseHelper, match-based test…
T-Gro Mar 27, 2026
fdf3d1c
Wave 8: Split TaggedStructAllNullary from when guard, remove dead fal…
T-Gro Mar 27, 2026
14f4a65
F10+F11: Remove duplicate comment, clean unreachable match arm
T-Gro Mar 27, 2026
f44dc98
Round 2: Domain model improvements (F1+F5+F7+F8+F4)
T-Gro Mar 27, 2026
91044ff
Round 2b: CaseIdentity, CaseStorage broadened, renames, dedup
T-Gro Mar 27, 2026
fb95901
Perf: struct CaseIdentity, inline CaseIsNull AP, eliminate allocations
T-Gro Mar 27, 2026
30319c5
Eliminate redundant classifyFromSpec/baseTyOfUnionSpec in EraseUnions
T-Gro Mar 27, 2026
9885a7e
Readability: extract nullable rewrite helper, improve comments
T-Gro Mar 27, 2026
9a3f9f6
Phase 4: emitIsCase+emitBranchOnCase → CaseStorage × DiscriminationMe…
T-Gro Mar 27, 2026
b9a283f
Phase 4: Architecture docs, InteropCapability, reduce mkMethodsAndPro…
T-Gro Mar 27, 2026
74db080
Remove speculative InteropCapability code
T-Gro Mar 27, 2026
f852f5c
Remove dead code: _validateActivePatterns, NonNullaryFoldsToRoot, Fie…
T-Gro Mar 27, 2026
3e7e8a7
Enrich DiscriminationMethod AP to carry baseTy and nullAsTrueValueIdx
T-Gro Mar 27, 2026
eed5871
Split EraseUnions.fs into 3 files by semantic boundary
T-Gro Mar 27, 2026
a104cd2
Fix bug + review findings: bounds check, stale comments, magic numbers
T-Gro Mar 27, 2026
e565cb4
DDD review: pure classification in Types.fs, architecture docs, secti…
T-Gro Mar 30, 2026
d629729
Council fixes: private mkMethodsAndPropertiesForFields, shared adjust…
T-Gro Mar 30, 2026
f5c8596
Fix: preserve exact IL for Option — add DataAccess.ViaOptionHelpers
T-Gro Mar 30, 2026
6896367
Merge branch 'main' into refactoring/erase-unions
T-Gro Mar 31, 2026
af061d4
Apply patch from /run fantomas
actions-user Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading