Fix #3939: Hide compiler-generated auto-property symbols from Symbols API#19498
Open
Fix #3939: Hide compiler-generated auto-property symbols from Symbols API#19498
Conversation
T-Gro
added
the
NO_RELEASE_NOTES
Contributor
|
T-Gro
force-pushed
the
fix/issue-3939-autoproperty-symbols
branch
from
6787bf3 to
291fb03
Compare
… API Fixes #3939 Mark the compiler-generated `v` setter parameter and backing field identifiers in auto-property desugaring with synthetic ranges, so they are excluded from GetAllUsesOfAllSymbolsInFile(). Previously these internal symbols leaked through the API with empty EnclosingEntity and misleading DisplayName/CompiledName values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
fix/issue-3939-autoproperty-symbols
branch
from
291fb03 to
32af463
Compare
…symbols Remove compiler-generated auto-property backing fields and setter parameter 'v' from expected symbol arrays in 'Test Project24 all symbols' and 'Test symbol uses of properties with both getters and setters'. These symbols are now correctly hidden by MakeSynthetic() ranges. Also merge with latest main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3939
Auto-property desugaring (
member val Foo = 123 with get, set) creates internal symbols (vsetter parameter,Foo@backing field) that leaked throughGetAllUsesOfAllSymbolsInFile()with emptyEnclosingEntityand misleading names.Fix: Mark these compiler-generated identifiers with synthetic ranges (
.MakeSynthetic()) inCheckDeclarations.fs, consistent with how other desugared constructs (computation expressions, record construction) handle this.Test: Un-skipped and rewrote the previously-skipped test
AutoProperty with get, set has property symbol 02to verify thevsymbol no longer appears. All 93 symbol tests pass.