Remove orphaned test data files and migrate FSharp.Data to NuGet

[Copilot]

Removes orphaned test data files and migrates FSharp.Data dependency from checked-in DLLs to NuGet package.

Deleted Files

• tests/service/data/sqlite-net-spike/ (entire folder)

  • Orphaned spike project never integrated into test suite
  • No references in solution files, project files, or tests
  • Project GUID {BE87D723-5EAB-4B69-8F65-5EC072EF9E46} appears nowhere else
  • Uses deprecated tooling (packages.config, .NET Framework 4.5, FSharp.Compiler.Tools 4.1.27)

• tests/service/data/FSharp.Data.DesignTime.dll

  • No references found in codebase
  • Replaced by NuGet package

• tests/service/data/FSharp.Data.dll

  • Replaced by NuGet package

FSharp.Data Migration to NuGet

• Added FSharp.Data version 6.6.0 as a PackageReference to FSharp.Compiler.Service.Tests.fsproj
• Created tests/FSharp.Compiler.Service.Tests/NuGet.Config to enable nuget.org as a package source
• Updated ProjectAnalysisTests.fs to reference FSharp.Data.dll from the test assembly output directory using PathRelativeToTestAssembly instead of hardcoded paths to checked-in files
• Project25 tests now use FSharp.Data from NuGet package, providing both runtime and design-time components

Verification

Code search confirmed zero references:

• sqlite-net-spike - only self-references within deleted folder
• FSharp.Data.DesignTime - no matches
• Project GUID - only in deleted .fsproj

All tests pass (2,074 passed, 0 failed, 29 skipped).

Original prompt

Summary

Remove unused/orphaned test data files from tests/service/data/ that are not referenced anywhere in the codebase.

Files to Delete

1. tests/service/data/sqlite-net-spike/ (entire folder)

This is a dead spike/prototype project that was never integrated into the test suite:

• Not referenced in any solution file (.sln)
• Not referenced in any project file (.fsproj, .csproj)
• Not referenced in any test file
• Not referenced in any CI/build configuration
• Project GUID {BE87D723-5EAB-4B69-8F65-5EC072EF9E46} appears nowhere else in the repository
• Uses legacy/obsolete tooling:
  • packages.config (deprecated)
  • Paket references
  • Targets .NET Framework 4.5
  • References FSharp.Compiler.Tools.4.1.27 (very old)

Files in this folder:

• sqlite-net-spike.fsproj
• Program.fs
• packages.config
• paket.references

2. tests/service/data/FSharp.Data.DesignTime.dll

This DLL file is completely orphaned:

• No references found anywhere in the codebase
• Searching for "FSharp.Data.DesignTime" returns zero results outside the file itself
• Note: FSharp.Data.dll (without "DesignTime") IS used by ProjectAnalysisTests.fs and should NOT be deleted

Verification

Code search was performed for:

• sqlite-net-spike - only found within the folder itself
• sqlitenetspike - only found within the folder itself
• BE87D723-5EAB-4B69-8F65-5EC072EF9E46 (project GUID) - only found in the .fsproj file itself
• FSharp.Data.DesignTime - no results

Impact

• No tests will be affected
• No builds will be affected
• Reduces repository size and maintenance burden

This pull request was created from Copilot chat.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[T-Gro]

@copilot , pls do:

Apparently this test needed the .dll of FSharp.Data.
Can you change the test to get it via nuget perhaps ?

Reproduce locally, fix, verify fix.

Failed FSharp.Compiler.Service.Tests.ProjectAnalysisTests.Test Project25 whole project errors [2 s]
Error Message:
Assert.Equal() Failure: Values differ
Expected: 0
Actual: 4
Stack Trace:
at FSharp.Compiler.Service.Tests.ProjectAnalysisTests.Test Project25 whole project errors() in D:\a_work\1\s\tests\FSharp.Compiler.Service.Tests\ProjectAnalysisTests.fs:line 3714
Standard Output Messages:
Project25 error: <<<The type 'XmlProvider' is not defined.>>>
Project25 error: <<<The type 'XmlProvider' is not defined.>>>
Project25 error: <<<The type 'Object' does not define the field, constructor or member 'GetSample'.>>>
Project25 error: <<<The value or constructor 'XmlProvider' is not defined.>>>

[github-actions]

✅ No release notes required

[github-actions]

✅ No release notes required

[Copilot]

@copilot , pls do:

Apparently this test needed the .dll of FSharp.Data.
...

Fixed in commit e7d6071. Changed the test to use FSharp.Data from NuGet package (version 6.6.0) instead of checked-in DLLs. The test now references PathRelativeToTestAssembly "FSharp.Data.dll" which resolves to the DLL from the NuGet package in the output directory.