PAT Migration: dn-bot-dnceng-public-build-r (telemetry)#6489
Open
missymessa wants to merge 12 commits intomainfrom
Open
PAT Migration: dn-bot-dnceng-public-build-r (telemetry)#6489missymessa wants to merge 12 commits intomainfrom
missymessa wants to merge 12 commits intomainfrom
Conversation
Migrate dnceng-public build-read PAT to the same telemetry-service-identity Managed Identity already used for dnceng (AB#10137). Changes: - settings.json: Remove AccessToken reference for dnceng-public - settings.Staging.json: Add ManagedIdentityClientId for dnceng-public - settings.Production.json: Add ManagedIdentityClientId for dnceng-public - telemetry-secrets.yaml: Deprecate dn-bot-dnceng-public-build-r - TelemetryManagedIdentityTests: Add dnceng-public/public post-deployment test Infrastructure (out-of-repo): - Added telemetry-service-identity MIs as service principals in dnceng-public org - Granted [public] Readers access to both prod and int MIs
Main had the dn-bot-dnceng-build-r entry removed (PR #6488), which shifted lines and conflicted with our deprecation comment block for dn-bot-dnceng-public-build-r. Keep our deprecation as intended.
Fully delete the dn-bot-dnceng-public-build-r entry and its manifest file instead of deprecating to type:text, per secret-manager tooling rules.
missymessa
force-pushed
the
missymessa-10138
branch
from
4ab7d4b to
7c2104e
Compare
The shared/telemetry-secrets.yaml was deleted (its only entry was the dn-bot-dnceng-public-build-r PAT). The vault configs still referenced it via importSecretsFrom, causing the Verify Secret Usages build step to fail with 'Could not find file'.
mmitche
reviewed
Apr 7, 2026
src/Telemetry/AzureDevOpsClient.PostDeploymentTests/TelemetryManagedIdentityTests.cs
Outdated
Show resolved
Hide resolved
mmitche
previously approved these changes
Apr 7, 2026
…edIdentityClientId Address review feedback: the 'placeholder-activates-bearer-path' string was not a valid client ID and didn't actually activate the bearer token path (UseManagedIdentity must be true for that). Use UseManagedIdentity = true, matching the other two tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item
AB#10138 — PAT Migration: dn-bot-dnceng-public-build-r
Summary
Migrates the \dn-bot-dnceng-public-build-r\ PAT to Entra bearer tokens using the same telemetry-service-identity Managed Identity already deployed for AB#10137 (dnceng org).
Code Changes (4 modified + 1 updated)
Configuration:
Secret Manager:
Tests:
Azure Resources Provisioned (out-of-repo)
Azure DevOps Organization Access (\dnceng-public):
Both MIs were added as service principals in the \dnceng-public\ Azure DevOps organization and granted Readers scope on the \public\ project.
Post-Merge Cleanup
After validating the MI works in production: