feat(forms): add filterable dropdown for roles in comment and assign … #34475
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form - Add filter functionality to role dropdown in DotCommentAndAssignFormComponent - Enable filtering by role label with [filter]=true and filterBy=label - Add translated filter placeholder using 'search' | dm pipe - Improves UX when dealing with large lists of roles
oidacra
requested review from
KevinDavilaDotCMS,
adrianjm-dotCMS,
hmoreras,
nicobytes,
rjvelazco and
zJaaal
adrianjm-dotCMS
approved these changes
Feb 2, 2026
KevinDavilaDotCMS
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PrimeNG dropdown filtering to the “Assign to role” selector in the comment/assign wizard step so users can quickly search roles in workflows with many assignable roles.
Changes:
- Enabled
p-dropdownfiltering (filter,filterBy="label",filterPlaceholder) on the roles dropdown in the comment/assign form. - Added a unit test asserting the dropdown’s filter-related inputs are enabled when the form is assignable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core-web/apps/dotcms-ui/src/app/view/components/_common/forms/dot-comment-and-assign-form/dot-comment-and-assign-form.component.html | Enables PrimeNG dropdown filtering and sets a localized filter placeholder for role search. |
| core-web/apps/dotcms-ui/src/app/view/components/_common/forms/dot-comment-and-assign-form/dot-comment-and-assign-form.component.spec.ts | Adds coverage ensuring the role dropdown filtering inputs are configured when assignable is true. |
dsolistorres
approved these changes
Feb 2, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add search/filter capability to the roles dropdown in the comment and assign form, improving usability when working with workflows that have many assignable roles.
Changes Made
Frontend
dot-comment-and-assign-form.component.htmlwith PrimeNG filter functionalityfilter,filterBy, andfilterPlaceholderproperties to enable searchable dropdownTechnical Details
This is a UX improvement that leverages PrimeNG's built-in dropdown filtering capabilities. The change adds three properties to the existing
p-dropdowncomponent:[filter]="true"- Enables the filter input boxfilterBy="label"- Configures filtering to match against the role's label property[filterPlaceholder]="'search' | dm"- Displays localized "search" placeholder text using dotCMS'sdmpipeThe dropdown already uses
appendTo="body"to prevent z-index issues, which ensures the filter input will render correctly in modal contexts.Breaking Changes
None
Testing
Related Issues
Closes #33061
Additional Notes
This is a minimal, focused change that improves the user experience without modifying any business logic or data structures. The PrimeNG dropdown component handles all filter functionality internally, making
this a low-risk enhancement.