fix(UVE): copy content modal error #34474
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rjvelazco
changed the title
copyContent modal Error
rjvelazco
changed the title
adrianjm-dotCMS
approved these changes
Feb 2, 2026
hmoreras
approved these changes
Feb 2, 2026
zJaaal
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an error in the UVE “copy content” modal by avoiding sending an empty-string variantId and aligning model typings to allow variantId to be omitted.
Changes:
- Update the UVE store page context
$variantIdcomputed to returnundefinedinstead of''when missing. - Make
DotTreeNode.variantIdoptional to support omitting it from requests when not applicable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/withPageContext.ts | Changes $variantId typing and default behavior to avoid empty-string values that can trigger API errors. |
| core-web/libs/dotcms-models/src/lib/dot-tree-node.model.ts | Makes variantId optional on DotTreeNode so callers can omit it when not applicable. |
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/withPageContext.ts
Show resolved
Hide resolved
…ontext and withEditor
oidacra
approved these changes
Feb 2, 2026
dario-daza
approved these changes
Feb 2, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…-parentpermissionable-for-container-variantid-bug
…-parentpermissionable-for-container-variantid-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #34300
Video
video.mov