feat(dot-browsing): Fix error in HostEdit Folder #34457
Merged
+174
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update tests ## Summary This commit introduces a parent reference in the tree structure for better data management and updates related tests to ensure functionality. ## Changes Made ### Models - Added `parent` property to `CustomTreeNode` in `dot-browser-selector.model.ts`. ### Store - Updated `HostFolderFiledStore` to utilize the new `CustomTreeNode` structure in `host-folder-field.store.ts`. ### Service - Modified `DotBrowsingService` to include the parent reference in the tree response in `dot-browsing.service.ts`. ### Tests - Expanded test cases in `dot-browsing.service.spec.ts` to validate the presence of the parent reference in tree structures for both single and multi-level paths. ## Technical Details The addition of the parent reference allows consumers of the tree structure to access the parent folder's hostname directly, improving the usability of the data model. ## Testing - [x] Unit tests added/updated to cover new functionality. - [x] Manual testing performed to verify tree structure integrity and parent reference accessibility.
1 task
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the "Host or Folder" field value was not displaying in the new Edit Mode for HTML pages. The root cause was that the parent property was missing from the tree structure returned by DotBrowsingService, causing the store code that accessed tree.parent.hostName to fail with a null reference error.
Changes:
- Added
parentproperty to theCustomTreeNodetype definition to include parent folder information - Modified
DotBrowsingService.buildTreeByPaths()to populate the parent reference in the tree response - Added explicit type annotation in
HostFolderFiledStorefor better type safety - Added comprehensive unit tests to verify the parent reference is always present in both single-level and multi-level folder paths
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core-web/libs/dotcms-models/src/lib/dot-browser-selector.model.ts |
Added optional parent?: DotFolder property to CustomTreeNode type and imported DotFolder model |
core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.ts |
Updated buildTreeByPaths() to include parent: node.parent in the tree structure; alphabetized imports |
core-web/libs/edit-content/src/lib/fields/dot-edit-content-host-folder-field/store/host-folder-field.store.ts |
Added CustomTreeNode type annotation and import; alphabetized imports |
core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.spec.ts |
Added two comprehensive test cases verifying parent reference exists for single and multi-level paths; alphabetized imports |
dario-daza
approved these changes
Jan 30, 2026
oidacra
reviewed
Jan 30, 2026
...t-content/src/lib/fields/dot-edit-content-host-folder-field/store/host-folder-field.store.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Jan 30, 2026
oidacra
approved these changes
Jan 30, 2026
…is-not-showing-up-in-new-edit-mode
…tailed documentation ### Changes Made - Added comprehensive JSDoc comments to `TreeNodeData`, `TreeNodeItem`, `TreeNodeSelectItem`, and `CustomTreeNode` types in `dot-browser-selector.model.ts` for better clarity on their structure and usage. - Updated `HostFolderFiledStore` to utilize the new `CustomTreeNode` type in `host-folder-field.store.ts`, ensuring type safety and improved readability. ### Motivation These enhancements improve the maintainability of the codebase by providing clear documentation for developers working with tree structures in the browser selector. ### Testing - Manual testing performed to verify that the tree structure functions correctly with the updated types.
nicobytes
deleted the
34275-defect-the-host-or-folder-field-value-is-not-showing-up-in-new-edit-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces a parent reference in the tree structure for better data management and updates related tests to ensure functionality.
Changes Made
Models
parentproperty toCustomTreeNodeindot-browser-selector.model.ts.Store
HostFolderFiledStoreto utilize the newCustomTreeNodestructure inhost-folder-field.store.ts.Service
DotBrowsingServiceto include the parent reference in the tree response indot-browsing.service.ts.Tests
dot-browsing.service.spec.tsto validate the presence of the parent reference in tree structures for both single and multi-level paths.Technical Details
The addition of the parent reference allows consumers of the tree structure to access the parent folder's hostname directly, improving the usability of the data model.
Testing
#34275
This PR fixes: #34275