Skip to content

fix(integration tests) #34422 : Adding new Workflow Step To Maven Job Action #34441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spbolton merged 4 commits into from
Jan 30, 2026
Merged

fix(integration tests) #34422 : Adding new Workflow Step To Maven Job Action #34441

spbolton merged 4 commits into from
Jan 30, 2026
+29 −0

Conversation

@jcastro-dotcms
Copy link
Contributor

@jcastro-dotcms jcastro-dotcms commented Jan 29, 2026 •
edited by github-actions bot
Loading

Proposed Changes

  • As part of the efforts to correctly use the more recent version of the Docker Maven Plugin to our build process, we need to add this new Workflow Step. This change was reviewed and approved via huddle by @spbolton and must be merged in order to move on to the next blocker in the build process.

This PR fixes: #34422

@jcastro-dotcms jcastro-dotcms requested a review from a team as a code owner January 29, 2026 18:55
@github-actions github-actions bot mentioned this pull request Jan 29, 2026
Closed
1 task
@erickgonzalez erickgonzalez linked an issue Jan 29, 2026 that may be closed by this pull request
[DEFECT] Docker Maven Plugin fails when running test-integration-ide command #34422
Closed
1 task
dcolina
dcolina approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@dcolina dcolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spbolton spbolton disabled auto-merge January 30, 2026 13:14
@spbolton
Copy link
Contributor

spbolton commented Jan 30, 2026

Testing on core-workflow-test showed an error we need to fix before merging this.

jcastro-dotcms and others added 3 commits January 30, 2026 07:26
@jcastro-dotcms
Merge branch 'main' into issue-34422-adding-new-workflow-step-to-mave…
6efd474 
…n-job-action
@jcastro-dotcms
Merge branch 'main' into issue-34422-adding-new-workflow-step-to-mave…
afdb575 
…n-job-action
@spbolton @claude
fix(ci): add SDKMAN_JAVA_VERSION build arg to docker build in maven-job
a157458 
Fixes the docker build failure caused by missing SDKMAN_JAVA_VERSION build argument.

- Add get-sdkman-version step to extract Java version from .sdkmanrc
- Pass SDKMAN_JAVA_VERSION as build arg to docker build command
- Add error handling if .sdkmanrc is not found

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@spbolton
Copy link
Contributor

spbolton commented Jan 30, 2026

This now contains the working code that passed on the core-workflow-test branch with this build run. It shows the independent docker build that now allows the docker save step after to work https://github.com/dotCMS/core-workflow-test/actions/runs/21519223635/job/62005574381#step:6:11175

@spbolton spbolton enabled auto-merge January 30, 2026 17:31
@spbolton spbolton added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit b7223ac Jan 30, 2026
38 checks passed
@spbolton spbolton deleted the issue-34422-adding-new-workflow-step-to-maven-job-action branch January 30, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erickgonzalez erickgonzalez erickgonzalez approved these changes

@dcolina dcolina dcolina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

dotCMS - Product Planning
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DEFECT] Docker Maven Plugin fails when running test-integration-ide command

5 participants

@jcastro-dotcms @spbolton @erickgonzalez @dcolina