feat(style-editor): Hide Style editor palette on delete/move contentlets #34440
+399
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd movement This commit enhances the EditEmaEditorComponent by adding functionality to check and reset the active contentlet when it is deleted or moved. Key changes include: - Introduced a private method to verify if the active contentlet still exists in the page containers. - Updated the component's logic to call this method during contentlet deletion and movement operations. - Enhanced unit tests to cover the new behavior, ensuring that the active contentlet is reset appropriately when it is no longer present. This update improves the reliability of contentlet management within the editor, ensuring that the UI state remains consistent with the underlying data model.
3 tasks
3 tasks
KevinDavilaDotCMS
requested review from
adrianjm-dotCMS,
dario-daza,
fmontes,
hmoreras,
nicobytes,
oidacra,
rjvelazco and
zJaaal
zJaaal
approved these changes
Jan 29, 2026
dario-daza
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #34425 where deleted contentlets would reappear in the UVE when the Style Editor form remained open. The solution adds logic to detect when the active contentlet being edited has been deleted or moved to a different container, and automatically resets the active contentlet state, which causes the Style Editor form to close/hide.
Changes:
- Added
resetActiveContentlet()method to the store to clear the active contentlet state - Implemented
#checkAndResetActiveContentlet()helper method that verifies if the active contentlet still exists in its original container - Integrated the check into delete, move, and temp insert operations to ensure the Style Editor closes appropriately
- Added comprehensive test coverage for delete and move scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts |
Adds resetActiveContentlet() method to reset the active contentlet state, and alphabetically reorders imports |
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts |
Implements #checkAndResetActiveContentlet() method and calls it after delete/move/temp insert operations; alphabetically reorders imports |
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.spec.ts |
Adds comprehensive tests covering delete and move scenarios for the active contentlet reset functionality; alphabetically reorders imports |
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Show resolved
Hide resolved
KevinDavilaDotCMS
deleted the
34425-defect-deleted-contentlet-reappears-in-uve-when-style-editor-form-remains-open
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2026-01-29.13-16-07.mov
This PR fixes: #34425
This PR fixes: #34425