Skip to content

Conversation

@hmoreras
Copy link
Contributor

@hmoreras hmoreras commented Jan 28, 2026

Proposed Changes

  • Clarified that secondary CSS variables are updated dynamically via setColor() method
  • Documented that Angular components using CSS variables directly (e.g., bg-(--color-palette-secondary-200)) receive dynamic updates
  • Explained the distinction between PrimeNG semantic tokens (preset only) vs CSS variables (dynamic)
  • Updated comments in updatePrimeNGColors() to explain why secondary semantic tokens aren't updated
  • Updated theme.config.ts comments to clarify secondary behavior

This PR fixes: #33882

This PR fixes: #33882

@semgrep-code-dotcms-test
Copy link

Legal Risk

The following dependencies were released under a license that
has been flagged by your organization for consideration.

Recommendation

While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.

GPL-2.0

MPL-2.0

@hmoreras hmoreras merged commit 4617367 into issue-33882-primeng-update Jan 28, 2026
7 checks passed
@hmoreras hmoreras deleted the issue-33882-primeng-update-dynamic-colors branch January 28, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants