-
Notifications
You must be signed in to change notification settings - Fork 40
Add 2025 Year in review insight #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Move the file * Update paths where the file is used
This works in prod today because of redirects but let's skip that and go directly to the report.
This allows for an arbitrary number of reports and makes the title optional.
Key changes: * Adds "DORA 2025: Year in review" insight article. * Styling: Updated `section.scss` to add `.centered-report-gallery` styles for better alignment and responsiveness of the report gallery. * Tests: Added a new Playwright spec `dora-2025-yir.spec.ts` to verify page content and metadata.
|
Visit the preview URL for this PR (updated for commit 110d395): https://doradotdev--pr1275-drafts-on-irn1xmaw.web.app (expires Fri, 06 Feb 2026 16:59:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new '2025 Year in review' insight page, which is a great addition. The changes also include a nice refactoring of the report_gallery shortcode to make it more dynamic and reusable, along with new styles and Playwright tests.
My review focuses on a few key areas. There's a critical accessibility issue with the updated report_gallery where missing titles can lead to links without accessible names. I've also pointed out some opportunities to improve maintainability in the new Markdown file by replacing inline styles with CSS classes and using absolute paths for images, which aligns with repository rules for robust image path resolution.
By the way, why did the coffee file a police report? It got mugged!
This post originated there, let's link to it.
Use the specific 'alt' text if specified, otherwise fallback to the title.
davidstanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was originally published on LinkedIn and has been republished on dora.dev
Preview URLs: