refactor(guides): rename four keys guide to dora metrics and add history #1270
Conversation
|
Visit the preview URL for this PR (updated for commit 25fd5bc): https://doradotdev--pr1270-drafts-off-lzo5cjqi.web.app (expires Sun, 01 Feb 2026 22:15:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the 'four keys' guide to 'DORA Metrics' to align with the updated five-metric model. The changes are comprehensive, including the addition of a metric history page, updating all internal links, adding necessary redirects, and refactoring the corresponding tests. I've found a few typos and a broken link that should be addressed. I also have a suggestion for the new dora_callout component regarding the use of a deprecated font. Overall, this is a solid refactoring effort. Why did the coffee file a police report? It got mugged!
nathenharvey
force-pushed
the
push-yllntqlustnm
branch
from
17bfe53 to
23b90fa
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a well-executed refactoring, updating the "Four Keys" guide to "DORA Metrics" to align with the newer five-metric model. The changes are comprehensive, covering content renaming, link updates, redirects, and new tests. The addition of a history page is a great touch for providing context. I've identified a few minor inconsistencies where the old "four keys" terminology remains within the updated content itself, and have provided suggestions to address these for consistency. Comments regarding pre-existing issues in other files have been omitted as they are outside the scope of this pull request. Overall, this is a solid improvement to the documentation.
Refactors the "Four Keys" guide to "DORA Metrics" to better align with the expanded 5-metric model and the latest DORA research. Key changes: - Renames content directory from `dora-metrics-four-keys` to `dora-metrics`. - Adds a new `history.md` page detailing the evolution of DORA’s metrics. - Updates internal links across capabilities, concepts, and resources pages. - Adds redirects in `firebase.json` and `redirects.csv` to ensure backward compatibility. - Implements a new `dora_callout` shortcode with associated SCSS for highlighted content. - Updates Playwright tests: removes old four-keys specs and adds `dora-metrics.spec.ts`. - Updates `core_data.json` in core-v2 to point to the new guide URLs.
nathenharvey
force-pushed
the
push-yllntqlustnm
branch
from
23b90fa to
25fd5bc
Compare
Refactors the "Four Keys" guide to "DORA Metrics" to better align with the expanded 5-metric model and the latest DORA research.
Key changes:
dora-metrics-four-keystodora-metrics.history.mdpage detailing the evolution of DORA’s metrics.firebase.jsonandredirects.csvto ensure backward compatibility.dora_calloutshortcode with associated SCSS for highlighted content.dora-metrics.spec.ts.core_data.jsonin core-v2 to point to the new guide URLs.Preview URLs: