Skip to content

Conversation

@nathenharvey
Copy link
Collaborator

@nathenharvey nathenharvey commented Dec 19, 2025

Extracts common table styles into a new partial _tables.scss and imports it globally.

This replaces the duplicated table style blocks previously found in ai.scss, research.scss, and capabilities.scss.

This change ensures consistent styling for all tables within the main content area (main table) and specifically fixes the unstyled "Four Mindsets" table on the AI Research page, which was previously missing styles due to a CSS selector mismatch.

The change also removes another instance of font-family: $font-roboto; from the site.

Preview links:

Fixes #1236

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a great refactoring that centralizes duplicated table styles into a new _tables.scss partial, improving maintainability by reducing code duplication. This change also fixes an issue with an unstyled table on the AI page by using a more general main table selector. I have one suggestion regarding the font-family for table cells in the new partial, which seems to have been missed during the refactoring and could cause an unintended visual change. Overall, excellent work on cleaning up the SCSS! Why did the coffee file a police report? It got mugged!

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Visit the preview URL for this PR (updated for commit 72b7cf9):

https://doradotdev--pr1260-drafts-off-4o3enmih.web.app

(expires Sun, 18 Jan 2026 22:31:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7ad2b3cf9cceb558b493931176f998ae46924361

Extracts common table styles into a new partial `_tables.scss` and imports it globally.

This replaces the duplicated `table` style blocks previously found in `ai.scss`, `research.scss`, and `capabilities.scss`.

This change ensures consistent styling for all tables within the main content area (`main table`) and specifically fixes the unstyled "Four Mindsets" table on the AI Research page, which was previously missing styles due to a CSS selector mismatch.

Fixes #1236
Copy link
Collaborator

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidstanke davidstanke merged commit a8d4e9c into main Dec 19, 2025
7 checks passed
@davidstanke davidstanke deleted the push-ztluxuzpstzn branch December 19, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Builder mindset - table difficult to read

3 participants