Skip to content

Conversation

@davidstanke
Copy link
Collaborator

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the text for the hero link on the homepage. However, this change introduces a critical issue by breaking an existing end-to-end test in test/playwright/tests/homepage.spec.ts. The test still asserts the presence of the old link text, which will cause the CI pipeline to fail. It's crucial to update tests along with functional changes to maintain the integrity of the test suite. On a lighter note, as per the style guide, I must point out the lack of coffee-related humor. So, here's one for you: Why did the coffee file a police report? It got mugged!

{{< homepage/hero
href="https://cloud.google.com/resources/content/2025-dora-ai-capabilities-model-report"
text="Read our latest report"
text="Read our latest RAD report"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This text change from "Read our latest report" to "Read our latest RAD report" will cause the Playwright test hero report link is visible and correct. to fail. The test, located in test/playwright/tests/homepage.spec.ts, specifically looks for the old text and will no longer find the element.

To fix this, the test needs to be updated to look for the new text. Failing to update tests alongside code changes leads to a broken build and undermines the reliability of the test suite.

In test/playwright/tests/homepage.spec.ts, you should update the following:

test('hero report link is visible and correct.', async ({ page }) => {
  const heroButton = page.getByRole('link', { name: 'Read our latest RAD report' }); // <-- This line needs to be updated
  await expect(heroButton).toBeVisible();
  await expect(heroButton).toHaveAttribute('href', 'https://cloud.google.com/resources/content/2025-dora-ai-capabilities-model-report');
});
References
  1. Per the style guide (lines 5-12), correctness is a key focus. This change breaks an existing test, which means the code no longer functions as intended from a testing perspective, violating the correctness principle. (link)

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Visit the preview URL for this PR (updated for commit 830a814):

https://doradotdev--1239-drafts-on-7gwegd0j.web.app

(expires Sun, 11 Jan 2026 21:04:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7ad2b3cf9cceb558b493931176f998ae46924361

@davidstanke davidstanke deleted the ci-dummy branch December 12, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants