Skip to content

Conversation

@Robin-St
Copy link

This is to close #396.

The find_item methods are extended with the argument only_active that defaults to true to keep the old behaviour intact. The various delete functions calls find_item with only_active=False to find any inactive items and be able to delete them.

Test cases are added with copies of the various test cases to remove an item but to try remove req5 that is inactive. Some test files used the test cases in the tutorial folder, as I could not find an inactive req there I added tut26 as an inactive case in that folder.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.35%. Comparing base (f34c454) to head (987a839).
⚠️ Report is 209 commits behind head on develop.

Files with missing lines Patch % Lines
doorstop/core/tree.py 42.85% 4 Missing ⚠️
doorstop/core/document.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #619      +/-   ##
===========================================
- Coverage    95.50%   95.35%   -0.16%     
===========================================
  Files           41       41              
  Lines         5053     5059       +6     
  Branches      1184     1187       +3     
===========================================
- Hits          4826     4824       -2     
- Misses         143      150       +7     
- Partials        84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doorstop remove does not remove inactive requirements

2 participants