Conversation
4.0.0 does not have support for versions prior to 8.2
Pin terminus 3.6.2 for PHP 8.1
📝 WalkthroughWalkthroughBumps PHP base images and updates pinned versions of Composer 2, WP-CLI, Acquia CLI, jq, yq across Dockerfiles for 8.1–8.4. Terminus updated to 4.1.0 for 8.2–8.4; 8.1 keeps 3.6.2 with an added pin comment. No control-flow or build-step structural changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- PHP 8.1.33 - PHP 8.2.29 - PHP 8.3.26 - PHP 8.4.13
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
8.1/Dockerfile(1 hunks)8.2/Dockerfile(1 hunks)8.3/Dockerfile(1 hunks)8.4/Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Build: 8.4/arm64
- GitHub Check: Build: 8.1/amd64
- GitHub Check: Build: 8.3/arm64
- GitHub Check: Build: 8.1/arm64
- GitHub Check: Build: 8.4/amd64
- GitHub Check: Build: 8.2/arm64
- GitHub Check: Build: 8.2/amd64
- GitHub Check: Build: 8.3/amd64
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
8.2/Dockerfile (1)
171-196: Optional: add checksum verification for downloaded tools.
Use upstream-provided SHA256 sums to harden supply chain.Example for composer2 within this RUN block:
- curl -fsSL "https://github.com/composer/composer/releases/download/${COMPOSER2_VERSION}/composer.phar" -o /usr/local/bin/composer2; \ + curl -fsSL "https://github.com/composer/composer/releases/download/${COMPOSER2_VERSION}/composer.phar" -o /usr/local/bin/composer2; \ + curl -fsSL "https://github.com/composer/composer/releases/download/${COMPOSER2_VERSION}/composer.phar.sha256sum" -o /tmp/composer2.sha256sum; \ + (cd /usr/local/bin && sha256sum -c /tmp/composer2.sha256sum); \8.3/Dockerfile (1)
171-196: Optional: checksum verification for downloads.
Same approach as suggested in 8.2 to validate artifacts at build time.8.4/Dockerfile (1)
171-196: Optional: checksum verification for downloads.
Recommend validating at least the core tooling (composer2, terminus, wp, acli).8.1/Dockerfile (1)
171-196: Optional: checksum verification for downloads.
Same as other versions; add SHA256 checks where feasible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
8.1/Dockerfile(2 hunks)8.2/Dockerfile(2 hunks)8.3/Dockerfile(2 hunks)8.4/Dockerfile(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Build: 8.2/amd64
- GitHub Check: Build: 8.1/amd64
- GitHub Check: Build: 8.3/amd64
- GitHub Check: Build: 8.1/arm64
- GitHub Check: Build: 8.2/arm64
- GitHub Check: Build: 8.4/arm64
- GitHub Check: Build: 8.3/arm64
- GitHub Check: Build: 8.4/amd64
🔇 Additional comments (8)
8.2/Dockerfile (2)
1-1: Base image bump LGTM.
161-169: Verified all specified release assets exist for amd64 and arm64 (all URLs returned HTTP 200).8.3/Dockerfile (2)
1-1: Base image bump LGTM.
161-169: Asset availability verified for all bumped versions (all URLs returned HTTP 200).8.4/Dockerfile (2)
1-1: Base image bump LGTM.
161-169: Assets validated: all bumped tool versions (including Terminus 4.1.0) returned HTTP 200.8.1/Dockerfile (2)
1-1: Base image bump LGTM.
160-169: Version bumps OK; all tools confirmed PHP 8.1 compatible. Acquia CLI requires ^8.1; WP-CLI’s ^8.0 covers 8.1. Terminus pin rationale preserved.
Summary by CodeRabbit