Remove duplicate splitArgs function

[ericcurtin]

We have an exact duplicate in utils

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code maintainability and reducing redundancy by centralizing a utility function. It removes a locally defined argument splitting function and replaces its usage with an existing shared utility, ensuring a single source of truth for this functionality across the codebase.

Highlights

• Code Duplication Removal: The pull request eliminates a duplicate splitArgs function that was present in main.go. This function's logic is already available in the pkg/utils package.
• Refactored Argument Splitting: The createLlamaCppConfigFromEnv function in main.go now utilizes the shared utils.SplitArgs function instead of its own local implementation, promoting code reuse and consistency.
• Dependency Management: The main.go file's imports have been updated to remove the strings package (as it was only used by the removed local function) and add the github.com/docker/model-runner/pkg/utils package.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request successfully removes a duplicated splitArgs function from main.go, replacing it with a call to a shared version in the pkg/utils package. The changes are correct and include updating the imports by removing the now-unused strings package. This is a good refactoring that improves code maintainability by reducing duplication.