Rename PackageName.main to .base to making naming consistent#3084
Open
Rename PackageName.main to .base to making naming consistent#3084
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5265688 bin/dub
rough build time=56sFull build output |
thewilsonator
approved these changes
Dec 27, 2025
WebFreak001
approved these changes
Dec 27, 2025
792ee2a to
58c8cce
Compare
Contributor
|
Some tests failure because I guess I should merge dlang-community/setup-dlang#94 since it's been staying there all this time, then you could do: - name: Install latest DMD
uses: dlang-community/setup-dlang@v2
with:
dc_format: basenameand the test should pass. Alternatively, making it less flasky is also a good idea: https://github.com/the-horo/dub/blob/ba66cf37fd8597fa830805872d169be1a957150d/test/new_tests/issue2012-dc-env/sample/app.d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is and has always been referred to "base package name" throughout the code base and should be named like this here, too, to avoid confusion.
Also reduces the amount of explicit attribute annotations a bit.