Fix: Prevent build conflicts by cleaning up stale library files#3068
Open
AripaStudio wants to merge 1 commit intodlang:masterfrom
Open
Fix: Prevent build conflicts by cleaning up stale library files#3068AripaStudio wants to merge 1 commit intodlang:masterfrom
AripaStudio wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your Pull Request and making D better! This comment will automatically be updated to summarize some statistics in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to address the issues reported in #312 and #311 by introducing a cleanup mechanism for stale library files before a new build. The primary goal is to prevent build conflicts that can arise from leftover files with
.lib,.a, or.soextensions.I have implemented a new function,
cleanupLibraryFiles, inbuild.dwhich is called before the build process starts. This function checks for and removes any old library build artifacts in the target path, ensuring a clean and consistent build environment.The changes were tested successfully using the following DUB project configuration, and no build errors were encountered:
{ "name": "test-dub", "description": "test", "authors": ["khashayar"], "dependencies": { }, "configurations": [ { "name": "application", "targetType": "executable", "sourceFiles": [ "source/app.d" ] }, { "name": "library", "targetType": "library", "sourceFiles": [ "source/test.d" ] } ] }