Split C++11-specific tests in their own file

[Geod24]

Follow up on the eager merge of #9138

[dlang-bot]

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9185"

[thewilsonator]

Thanks!

[Geod24]

Sweet, it does not work (except on Linux and MacOS ofc).
FreeBSD:

 ... runnable/cpp11.d               -stdc++=c++11  -fPIC -L-lstdc++ (-O -inline -release)
Test runnable/cpp11.d failed.  The logged output:
/home/braddr/sandbox/at-client/pull-3468076-FreeBSD_64_64/dmd/generated/freebsd/release/64/dmd -conf= -m64 -Irunnable -stdc++=c++11  -fPIC -L-lstdc++  -odgenerated/runnable -ofgenerated/runnable/cpp11_0  runnable/cpp11.d generated/runnable/cpp11.cpp.o 
generated/runnable/cpp11_0.o: In function `_D5cpp116test17FZv':
runnable/cpp11.d:(.text._D5cpp116test17FZv+0x7): undefined reference to `_Z8testnullDn'
runnable/cpp11.d:(.text._D5cpp116test17FZv+0x11): undefined reference to `_Z12testnullnullDnDn'
cc: error: linker command failed with exit code 1 (use -v to see invocation)

Windows:

 ... runnable\cpp11.d               -stdc++=c++11   (-inline -release -g -O)
Test runnable\cpp11.d failed.  The logged output:
..\generated\windows\release\32\dmd.exe -conf= -m64 -Irunnable -stdc++=c++11   -L/OPT:NOICF  -odtest_results\runnable -oftest_results\runnable\cpp11_0.exe  runnable\cpp11.d test_results\runnable\cpp11.cpp.obj  -map nul.map


cpp11_0.obj : error LNK2019: unresolved external symbol "void __cdecl testnullnull(std::nullptr_t,std::nullptr_t)" (?testnullnull@@YAX$$T$$T@Z) referenced in function _D5cpp116test17FZv



test_results\runnable\cpp11_0.exe : fatal error LNK1120: 1 unresolved externals



Error: linker exited with status 1120

@ibuclaw do you want to take a look at it or shall I ?

[ibuclaw]

I have no care for the windows mangling (itanium is used for all platforms including windows my end).

I have a FreeBSD VM around somewhere, however my initial assumption is that the version of gcc installed on the box is old (I think gcc 4.7 or older)

See my comment on abi timeline of nullptr_t.
#9130 (comment)

[ibuclaw]

You could try setting false if FreeBSD in the new target hook to verify.

if (isFreeBSD)
{
  substitute = false;
  return true;
} 

[rainers]

cpp11_0.obj : error LNK2019: unresolved external symbol "void __cdecl testnullnull(std::nullptr_t,std::nullptr_t)" (?testnullnull@@Yax$$T$$T@Z) referenced in function _D5cpp116test17FZv

VC uses back references for std::nullptr_t, too, so adding this to VisualCPPHndler.visit(TypeNull) should help:

+++ src/dmd/cppmanglewin.d
@@ -137,6 +137,8 @@ public:
     {
         if (checkImmutableShared(type))
             return;
+        if (checkTypeSaved(type))
+            return;
 
         buf.writestring("$$T");
         flags &= ~IS_NOT_TOP_TYPE;

[thewilsonator]

This is all green. Good to go?

[Geod24]

Well the test is disabled on most platforms, but this is why you should not merge commented out tests, they rarely work.
But yeah, let's go ahead and get this merged, given the bandwidth on C++1X I assume this will see use fairly soon.

[thewilsonator]

And that first commit should make it easier for Manu to do remote debugging.

[thewilsonator]

Auto-merge toggled on