Skip to content

Conversation

@fwolfst
Copy link

@fwolfst fwolfst commented Sep 20, 2025

Draft for #192

Description

User wants to delete projects, especially on devices with no or limited possibilities to delete files and directories "manually".

The most useful place to do so might be in the project view, because there we probably listened to and looked at the current project, whereas in the main(?) view the user would need to know the projects name in order to delete the correct one.

After deletion from the projects view, the user shall be presented the load/new ("main"?) view.

Findings and pointers so far:

  • make sure to free that projects/songs/instruments/... memory
  • there is no 'delete directory' functionality implemented yet
  • delete directory implementation will differ from platform to platform :(


Description

Thank you for contributing to Little Piggy Tracker!
For fixes, please include a summary of the changes and any related issue.
For features, please include a detailed description of the new feature and how it works.

All PR:s are run through line-by-line clang-format and builds for all supported platforms.
clang-format can be applied locally on commit by installing pre-commit from repo root:
cp pre-commit .git/hooks/

Fixes # (issue)

Type of change

Please delete option that isn't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions on how to reproduce.

Test Configuration:

  • Hardware:
  • OS version:

Checklist:

  • I have performed a self-review of my code
  • I have commented particularly in hard-to-understand areas
  • I have updated documentation regarding my changes
  • My changes generate no new warnings

@fwolfst fwolfst changed the title Add song deletion functionality Add song deletion functionality 🗑️ Sep 20, 2025
@djdiskmachine
Copy link
Owner

Hey thanks for making this!
I'm not sure it makes sense having the delete option in the project view, where would you end up when deleting a project when inside a project for instance?
I think having a load screen menu item and/or button combo makes the most sense. :)

@fwolfst
Copy link
Author

fwolfst commented Sep 24, 2025

Hey thanks for making this! I'm not sure it makes sense having the delete option in the project view, where would you end up when deleting a project when inside a project for instance? I think having a load screen menu item and/or button combo makes the most sense. :)

I certainly think its a bit more difficult to implement. Its the screen where I was searching the functionality, after having played with a track until I deemed it broken. (Brain: "go up, delete, create new"). When one opens the "Load (or new)" screen from there, the selected entry is the last song afaik, that would also work. In the project screen the current projects title is not avaible/visible. I wanted to patch that, but I couldnt figure out where to find the songs title.
Also note that there is no actual deletion code yet - unfortunately that'll need to get implemented per "filesystem".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants