Improve refresh_from_db to make it works with protected fields #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #61, FSMModelMixin is misleading: FSM-protected fields are just excluded from refresh_from_db, but in a concurrent context, having the ability to refresh the state fields looks crucial!
This PR updates the behavior to disable "protected" during refresh_from_db.
The fields are still protected from direct modification but refresh_from_db acts normally.
I'll let this PR open for a certain amount of time to gather some feedback. If you're using this feature feel free to give it a try (as I'm not using "protected" anymore, just
editable=False)