fix: Popup window name can contain more than one "__"

[fsbraun]

Description

The silent assumption that the popup window name only contains one set of dunder symbols (__) is broken, potentially by newer Django versions.

Now, only the last __ is cut from the pupup window name to find the widget it belongs to.

Related resources

• #...
• #...

Checklist

• I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #workgroup-pr-review on
  Slack to find a “pr review buddy” who is going to review my pull request.

[sourcery-ai]

Sorry @fsbraun, your pull request is larger than the review limit of 150000 diff characters

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.98%. Comparing base (18c25fc) to head (2f2d655).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1575   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files          78       78           
  Lines        3671     3671           
  Branches      498      498           
=======================================
  Hits         2826     2826           
  Misses        675      675           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fsbraun]

@sourcery-ai Ignore the bundle files for reviewing

[sourcery-ai]

Understood, I’ll ignore the bundle files when considering this PR and focus the review on the functional and source changes only.

[Copilot]

Pull request overview

This PR fixes a bug in the windowname_to_id function that parses popup window names. The function previously assumed window names contained only one set of double underscores (__), which could break with newer Django versions or complex naming patterns. The fix changes from using split('__')[0] to using lastIndexOf('__') with substring() to extract everything before the last occurrence of __.

Changes:

• Updated windowname_to_id function to use lastIndexOf("__") instead of split("__")[0]
• The bundled JavaScript file reflects this same change

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File	Description
filer/static/filer/js/addons/popup_handling.js	Core fix: changed window name parsing to find the last __ occurrence
filer/static/filer/js/dist/admin-file-widget.bundle.js	Bundled version containing the same fix

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.