fix: thumbstick #26
Closed
fix: thumbstick #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosmydel
force-pushed
the
kosmydel/fix-bottom-sheet-thumbstick
branch
from
cd4527b to
d3312e3
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes thumbstick issues on the Meta Quest. We need to test it on mobile devices to ensure it doesn’t break or change anything, or alternatively, hide it behind a prop/flag to enable it only on Quest devices
Test plan
Update the commit hash in
pnpm-workspace.yamlto thed3312e31dc553599e2ee6b13c1146d4680c7d9d5and verify the bottom sheets are working.