Skip to content

Conversation

@tdjames1
Copy link
Contributor

@tdjames1 tdjames1 commented Sep 4, 2025

Description

Display sample profile skill wheel visualisations on the roles page.

Fixes # (issue)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
main/views.py 94.11% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tdjames1
Copy link
Contributor Author

tdjames1 commented Sep 5, 2025

@AdrianDAlessandro I added tests, is there a way to persuade @codecov to run again?

Edit: it seems to have done it now!

@tdjames1
Copy link
Contributor Author

tdjames1 commented Sep 5, 2025

@davehorsfall Feel free to tweak the layout, here's how it's looking with the role description in place:

image

Updated profiles here for checking layout: https://github.com/direct-framework/direct-webapp/tree/487-add-sample-profile-desc

@davehorsfall
Copy link
Collaborator

@tdjames1 thanks, great work. I've adding styling for the page.

Copy link
Collaborator

@davehorsfall davehorsfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all works for me, and I've added some additional styling for the page.

@davehorsfall davehorsfall merged commit a040193 into main Sep 7, 2025
5 checks passed
@davehorsfall davehorsfall deleted the feat/454-role-profiles-page branch September 7, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants