Skip to content

Conversation

@davehorsfall
Copy link
Collaborator

Description

PR that adds a conditional redirect on login for users. If the user has already defined skills, they are redirected to their skill profile. Otherwise, they are sent to the self-assessment page to set up their skills.

Also

  • Added authenticated requirement to the skill profile page
  • Renamed the self-assess.html template to user_self_assess.html for consistency with other templates

Fixes #166

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
main/views.py 66.66% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@davehorsfall
Copy link
Collaborator Author

Supersedes #479

@davehorsfall davehorsfall mentioned this pull request Sep 4, 2025
11 tasks
@davehorsfall davehorsfall merged commit a0c1f7b into main Sep 7, 2025
5 checks passed
@davehorsfall davehorsfall deleted the feat/conditional-user-landing branch September 7, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Create app landing page

3 participants