-
-
Notifications
You must be signed in to change notification settings - Fork 328
Replace crossbeam channel with std::sync::mpsc #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crossbeam channel with std::sync::mpsc #861
Conversation
- Replace all uses of crossbeam::channel with std::sync::mpsc - Remove crossbeam dependency from all Cargo.toml files - Update documentation to remove crossbeam references - Use std::sync::mpsc::channel() instead of crossbeam::channel::unbounded() Fixes dimforge#828 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Thank you! I have tested it on wasm and confirm it’s working properly. |
|
Hey! I just want to mention that feature-wise |
|
Hey! Thank you for your feedback, I didn’t realize that difference between the two! rapier/src/pipeline/event_handler.rs Lines 93 to 134 in efa7e76
So, instead of re-thinking your current structure you can define your own Let me know if a custom implementation doesn’t work in your use-case. |
|
Thanks for the quick response — I haven't looked into that part at all, just noticed the giant compiler errors from an axum handler and traced back to there. Implementing the |
Replaced all uses of
crossbeam::channelwithstd::sync::mpscto reduce the dependency footprint.Changes
crossbeam::channel::{Sender, Receiver}tostd::sync::mpsc::{Sender, Receiver}crossbeam::channel::unbounded()tostd::sync::mpsc::channel()crossbeam = "0.8"dependency from 8 Cargo.toml filespub extern crate crossbeam;from src/lib.rsAs discussed in #828, crossbeam is only used for its channel implementation. Since std::sync::mpsc provides equivalent functionality for this use case, we can use the standard library instead.
Fixes #828