Skip to content

Conversation

@MartinRiese
Copy link
Contributor

@MartinRiese MartinRiese commented Sep 9, 2025

Product Description

Identify exceptions for missing lookup table references. Generate a web apps specific error message
using reference.

Technical Summary

https://dimagi.atlassian.net/browse/USH-6241

Safety Assurance

Pretty small change. Tested locally.

Safety story

Automated test coverage

QA Plan

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

cross-request: dimagi/commcare-core#1499

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.36%. Comparing base (9eb6f58) to head (ff75b54).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...yer/application/GlobalDefaultExceptionHandler.java 11.11% 8 Missing ⚠️
...player/beans/exceptions/ExceptionResponseBean.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1749      +/-   ##
============================================
- Coverage     70.43%   70.36%   -0.08%     
  Complexity     2032     2032              
============================================
  Files           257      257              
  Lines          7987     7995       +8     
  Branches        753      755       +2     
============================================
  Hits           5626     5626              
- Misses         2079     2087       +8     
  Partials        282      282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

For web apps the error message for missing look up tables can/should be
more specific
@MartinRiese MartinRiese changed the title Set the type to html when exceptions have html msg Generate formplayer specific error msg for missing lookup tables Sep 18, 2025
@MartinRiese MartinRiese merged commit 929994f into master Sep 19, 2025
4 of 6 checks passed
@MartinRiese MartinRiese deleted the riese/err_html branch September 19, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants