Skip to content

Conversation

@us77ipis
Copy link
Contributor

@us77ipis us77ipis commented Oct 14, 2025

  • Fix some queries involving aggregates throwing an exception on execution
  • Consistently allow to reannotate any field names when querying from a CTE
  • For Django >= 5.2:
    • Guarantee, in accordance with the new Django 5.2 behavior, the order of the selected fields when querying from a CTE without calling again values() or values_list() on the queryset
    • Propagate correct values_list() behavior when querying from a CTE

@us77ipis us77ipis force-pushed the main branch 3 times, most recently from 70c4f1e to de564d2 Compare October 15, 2025 12:53
Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@us77ipis thanks for improving django-cte. Do the changes in this PR break backward compatibility in a way that we need to announce, and possibly bump the minor version number?

Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of nitpicky comments, but this is looking good.

Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@us77ipis, Thank you!

@millerdev millerdev merged commit 4a77a64 into dimagi:main Oct 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants