Github deploy action #151
Merged
Github deploy action #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravfeyn
commented
Jul 3, 2025
| default: 'staging' | ||
| type: choice | ||
| options: | ||
| - production |
Member
Author
There was a problem hiding this comment.
This is pretty much redundant and not used, but I have kept it anyway
sravfeyn
commented
Jul 3, 2025
| uses: shimataro/[email protected] | ||
| with: | ||
| key: ${{ secrets.SSH_KEY }} | ||
| known_hosts: ${{ secrets.KNOWN_HOSTS }} |
Member
Author
There was a problem hiding this comment.
I have added these to the github secrets
.github/workflows/deploy.yml
Outdated
| inputs: | ||
| environment: | ||
| required: true | ||
| default: 'staging' |
Contributor
There was a problem hiding this comment.
Is it intentional to set the default to staging even though staging is not one of the available choices?
hemant10yadav
approved these changes
Jul 3, 2025
Contributor
hemant10yadav
left a comment
hemant10yadav
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been hard to deploy from Mac (with Apple Silicon), this should make it easy to deploy. I have adapted this from commcare-connect github deploy action. Currently, it doesn't have the slackbot integration. PR for that is seperate #152