Encrypt API keys #122
Open
Encrypt API keys #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
reviewed
Jan 1, 2026
|
|
||
| # Generate with `from cryptography.fernet import Fernet; Fernet.generate_key()` | ||
| FERNET_KEYS = [ | ||
| 'sGylGjTyNm64l4-F448DiMjS6cE1qZ9b5UZWPxTu2po=', |
There was a problem hiding this comment.
Is this a test key? Does it make sense to remove it from this file since we would not want someone to accidentally use a publicly available test key in a production setup?
| # Generate with `from cryptography.fernet import Fernet; Fernet.generate_key()` | ||
| FERNET_KEYS = [ | ||
| 'sGylGjTyNm64l4-F448DiMjS6cE1qZ9b5UZWPxTu2po=', | ||
| # Current key at the top, previous keys below |
There was a problem hiding this comment.
Is the idea here to add automation to try older keys if the new one does not work? I don't see any such automation in this PR. Is that planned for the future, or does the list have a different purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦖 SAAS-19046
🐡