Remove RELEASE_BUILDS_PER_PROFILE feature flag#37391
Merged
Conversation
- toggle_build_profile, already removed from html templates - toggle_release_restriction_by_app_profile, no longer functional after FF removal
…ve related code and strip methods
015611a to
7a5c578
Compare
Also remove tests for functionality that no longer exists
43b9f1b to
257967e
Compare
jingcheng16
reviewed
Feb 20, 2026
| ('forced', self.build_profile_id, {'value': self.v2_build.version, 'force': True}), | ||
| ('off', {}), | ||
| ('on', {'value': self.v3_build.version, 'force': False}), | ||
| ('forced', {'value': self.v3_build.version, 'force': True}), |
Contributor
There was a problem hiding this comment.
Seems like you removed test case for v2_build and v2_build is never referenced in this test, thus can be removed from the test class?
Contributor
There was a problem hiding this comment.
build_profile_id and build_profiles can be removed as well.
Contributor
There was a problem hiding this comment.
Can you help me understand what does this test and do we need to make new versions in setupClass()?
Contributor
Author
There was a problem hiding this comment.
Previously it was making a build profile id-specific version, so depending on whether a build profile id was passed in, you'd get back a different version. You're correct that the extra build isn't doing anything special anymore, it's just incrementing the version and can be removed.
jingcheng16
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
No user-facing changes. This PR removes deprecated backend code that is no longer in use.
Technical Summary
https://dimagi.atlassian.net/browse/SAAS-19317
This PR removes the deprecated
RELEASE_BUILDS_PER_PROFILEfeature flag and all associated code. The feature flag was introduced in December 2018 (PR #22736) to enable selective build releases for app profiles, but has been marked asTAG_DEPRECATEDand is no longer in use.This removes all uses of the
LatestEnabledBuildProfilesmodel,ManageReleasesByAppProfileview and forms, related utility functions, and UI elements from templates.Note:
LatestEnabledBuildProfilesmodel is kept for now and should be removed in a follow-up PR in ~6 weeks, to allow time for self-hosters to deploy this code.Feature Flag
Removes:
RELEASE_BUILDS_PER_PROFILESafety Assurance
Safety story
This change is safe because:
TAG_DEPRECATED, indicating it should not be usedTested on staging that:
Automated test coverage
QA Plan
No formal QA needed.
Rollback instructions
Labels & Review
(PR description co-written by Claude)