Skip to content

Remove TransferDomainRequest and references#37355

Merged
nospame merged 2 commits intomasterfrom
ejp/remove-transferdomainrequest
Feb 19, 2026
Merged

Remove TransferDomainRequest and references#37355
nospame merged 2 commits intomasterfrom
ejp/remove-transferdomainrequest

Conversation

@nospame
Copy link
Contributor

@nospame nospame commented Feb 16, 2026

Technical Summary

https://dimagi.atlassian.net/browse/SAAS-19359
This removes the TransferDomainRequest model, as no live projects have completed domain transfer records on dimagi environments. Live code referencing this model was removed in #37346

Safety Assurance

Safety story

This is straightforward as model deletions go - no other models or still-existing code depend on this model, and previous code was feature flagged. Ensuring #37346 is deployed first makes sure there are no unexpected errors because of references to this model when the migration is run on a live environment.

Automated test coverage

Test cases for the removed TransferDomainRequest have been removed. Tests for domain dump and deletion that look at related models still pass as the references to this model have been removed.

QA Plan

Not planning it.

Migrations

  • The migrations in this code can be safely applied first independently of the code. Pay particular attention to backward incompatible operations like RemoveField, RenameField, RemoveConstraint, and others described here that can cause errors when migrations are applied to a live database.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations
    The migration here would first have to be reversed.

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@nospame nospame added the product/invisible Change has no end-user visible impact label Feb 16, 2026
@dimagimon dimagimon added the reindex/migration Reindex or migration will be required during or before deploy label Feb 16, 2026
millerdev
millerdev previously approved these changes Feb 17, 2026
Base automatically changed from remove-toggle/TRANSFER_DOMAIN to master February 17, 2026 16:55
@nospame nospame dismissed millerdev’s stale review February 17, 2026 16:55

The base branch was changed.

@nospame nospame marked this pull request as ready for review February 18, 2026 21:21
@nospame nospame merged commit 7bda61f into master Feb 19, 2026
18 checks passed
@nospame nospame deleted the ejp/remove-transferdomainrequest branch February 19, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product/invisible Change has no end-user visible impact reindex/migration Reindex or migration will be required during or before deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments