Move split screen case search under simple case search#37340
Open
MartinRiese wants to merge 5 commits intoes/case-search-ffsfrom
Open
Move split screen case search under simple case search#37340MartinRiese wants to merge 5 commits intoes/case-search-ffsfrom
MartinRiese wants to merge 5 commits intoes/case-search-ffsfrom
Conversation
dimagimon
added
the
Risk: Medium
MartinRiese
changed the base branch from
riese/migrate_case_list_config_options
to
master
MartinRiese
force-pushed
the
riese/migrate_sscs
branch
from
88d0ce0 to
53ed6be
Compare
MartinRiese
changed the title
MartinRiese
force-pushed
the
riese/migrate_sscs
branch
from
028e05b to
101f3f8
Compare
With SSCS (Split Screen Case Search) now the default behavior, the search_again_label is no longer needed. This removes all references to search_again_label and CaseSearchAgainLabel throughout the codebase. Changes: - Remove CaseSearchAgainLabel class and search_again_label/again_label properties from CaseSearch model - Remove search_again_label from views (GET/POST endpoints, media handling) - Remove search_again_label locale string generation - Remove search_again_label from media collection and renaming - Remove search_again_label from translation upload/download modules - Remove search_again_label from JavaScript (case_claim.js) - Update test fixtures and assertions to no longer expect search_again functionality - Clean up test data (plant_care_app.json) The search_again_label was previously used to provide a "Search Again" button on search results, but with SSCS this is no longer generated. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove SPLIT_SCREEN_CASE_SEARCH toggle checks from JavaScript and make split-screen case search always enabled, aligning with backend changes. The SPLIT_SCREEN_CASE_SEARCH toggle is frozen (TAG_FROZEN) and will be removed. The backend (commit 6f34a21) already generates split-screen suite XML unconditionally, so the JavaScript should match this behavior. Changes: - Remove toggle check from isSidebarEnabled() function in utils.js - Always enable split-screen UI when case search has data to display - Update analytics tracking to always report split-screen as enabled - Remove splitScreenToggleEnabled property and all dead code paths - Remove non-split-screen search container from case list template - Remove toggle stub and obsolete test from split_screen_case_search_spec The split-screen UI is now always available for domains with case search, controlled by the parent toggle SYNC_SEARCH_CASE_CLAIM (Simple Case Search). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The backend no longer checks this toggle, so test decorators and toggle
dict entries are dead code.
- Remove @flag_enabled('SPLIT_SCREEN_CASE_SEARCH') from Python tests
- Remove SPLIT_SCREEN_CASE_SEARCH from JS test toggle dicts
- Fix search_on_clear tests to use correct CASE_SEARCH_ADVANCED toggle
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MartinRiese
force-pushed
the
riese/migrate_sscs
branch
from
101f3f8 to
64e3b6e
Compare
MartinRiese
requested review from
Robert-Costello and
nospame
as code owners
No more search again action we need to find
MartinRiese
force-pushed
the
riese/migrate_sscs
branch
from
6e2aec6 to
abc152a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
Make split screen case search the default under the simple case search FF.
Technical Summary
https://dimagi.atlassian.net/browse/USH-6465
Feature Flag
Safety Assurance
Safety story
Automated test coverage
Updated tests
QA Plan
Rollback instructions
Labels & Review