-
-
Notifications
You must be signed in to change notification settings - Fork 231
Add 4 new geo formats in Case List property config for display properties #37221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes the issue where current logic simply removes the last element which may or may not be translatable enum
… is selected, exceute on page load
| } else { | ||
| // Restrict Translatable Text usage to Calculated Properties only | ||
| menuOptions.splice(-1); | ||
| const index = menuOptions.findIndex(f => f.value.includes('translatable-enum')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minhaminha
I noticed this was removing the last element in the array, so I modified it to remove the correct element. Let me know if it looks correct to you.
zandre-eng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but generally looks fine given that this is going through QA.
corehq/apps/app_manager/static/app_manager/js/details/screen.js
Outdated
Show resolved
Hide resolved
zandre-eng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, looks good!
this is done as it is supposed to be used only for mobile app
|
Where is the xml actually generated and do you have an example suite file with the new fields? |
(Updated the example code and suite file in this comment) FYI @calellowitz Attaching the sample suite file with a Below is the example how one of the field looks like |
Product Description
1. Geo Boundary (requires Address)
2. Geo Boundary Color (requires Geo Boundary)
3. Geo Points (requires Address)
4. Geo Points Colors (requires Geo Points)
New.Formats.mp4
Validation.mp4
Technical Summary
Ticket
Feature Flag
None
Safety Assurance
Safety story
Tested on Local. QA passed
Automated test coverage
JS changes only.
QA Plan
TBA
Rollback instructions
Labels & Review