Make celery/kombu and redis packages compatible for redis broker #37220
+49
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to run redis as a broker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Given we use redis as a broker in self hoster and local setups, this is something that we should do.
In addition to including the extra redis dependencies for celery, I've upgraded celery/kombu as part of this. Notably this does result in downgrading the redis client package version, but that is to ensure compatibility with kombu.
We upgraded to redis 7.1 a few weeks ago in #37133. So this is undoing that, and effectively going from 6.2 to 6.4.
Feature Flag
Safety Assurance
Safety story
Tested on staging
Automated test coverage
QA Plan
No
Rollback instructions
Labels & Review