B5 Migration: Split App Manager #37218
Open
+31,538
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als/modules/module_view_case_type.html, splitting templates"
…als/appnav_menu_header.html, splitting templates"
…als/releases/app_release_logs.html, splitting templates"
…als/forms/form_view_modals.html, splitting templates"
…als/toggle_diff_modal.html, splitting templates"
…als/modules/case_tile_templates.html, splitting templates"
…als/releases/build_profiles.html, splitting templates"
…als/forms/form_tab_advanced.html, splitting templates"
…als/menu/appnav_menu.html, splitting templates"
…als/releases/releases_deploy_modal.html, splitting templates"
…als/modules/mobile_report_configs.html, splitting templates"
…als/forms/form_workflow.html, splitting templates"
…e_view.html, splitting templates"
…iew_settings.html, splitting templates"
…base.html, splitting templates"
…view.html, splitting templates"
…als/app_summary_button.html, splitting templates"
…als/modules/case_list_lookup.html, splitting templates"
…als/download_async_modal.html, splitting templates"
…als/forms/custom_assertions.html, splitting templates"
…als/settings/supported_languages.html, splitting templates"
…als/forms/shadow_parent_select.html, splitting templates"
…als/forms/case_config.html, splitting templates"
…summary.html, splitting templates"
…iff.html, splitting templates"
…als/modules/case_search_properties.html, splitting templates"
…ages.html, splitting templates"
…als/releases/releases_deploy_modal_sms.html, splitting templates"
…als/releases/releases.html, splitting templates"
…mmary/form_diff.js, splitting templates"
…tails/column.js, splitting templates"
…leases/releases.js, splitting templates"
…tails/screen.js, splitting templates"
…rms/form_designer.js, splitting templates"
…p_exchange.js, splitting templates"
…als/module_options/module_option_report.html, splitting templates"
…als/module_options/module_option_survey.html, splitting templates"
…als/module_options/module_option_advanced.html, splitting templates"
…als/module_options/module_option_shadow.html, splitting templates"
…als/module_options/module_option_training.html, splitting templates"
…als/module_options/module_option_biometrics.html, splitting templates"
…als/nav_menu_media.html, splitting templates"
…als/module_options/module_option_shadow_v1.html, splitting templates"
…als/module_options/module_option_case.html, splitting templates"
…wnload_index_main.js, splitting templates"
…dules/module_view_report.js, splitting templates"
…main.js, splitting templates"
…releases_spec.js, splitting templates"
…dules/module_view.js, splitting templates"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
https://dimagi.atlassian.net/browse/SAAS-18984
Splits App Manager to begin Bootstrap migration for the app; does not migrate anything yet.
The last commit was done manually and modifies webpack config to build b3 and b5 versions of a couple specific app manager files correctly. The rest are all automated, with:
Apologies for the size of this PR - that's just the size of the
app_managerdjango app.Safety Assurance
Safety story
Spot tested locally using vellum debug (i.e. vellum running from
submodules/formdesigner) both on and off, as well as on staging.Automated test coverage
For bootstrap diffs.
QA Plan
Not for this initial split.
Rollback instructions
This split can be reverted easily only if there have been no further changes in
app_managerfollowing its being merged.Labels & Review